Ensure that NI_Vector_Dot is always handled as TYP_SIMD - #88447
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsnull
|
kunalspathak
reviewed
Jul 7, 2023
| GenTree* sqrt = nullptr; | ||
| GenTree* toScalar = nullptr; | ||
|
|
||
| if (op1->OperIs(GT_INTRINSIC)) |
Contributor
There was a problem hiding this comment.
Wondering what are the examples where we now want to have varTypeIsFloating() check inside the OperIs(GT_INTRINSIC) check?
Member
Author
There was a problem hiding this comment.
The codegen for integers was already doing the "right thing" and producing vectors where the result is in all elements, so the varTypeIsFloating check was unnecessary. It's only needed in the case we have a GT_INTRINSIC in-between, in which case we can only handle Sqrt and only for floating-point
tannergooding
commented
Jul 7, 2023
Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
tannergooding
marked this pull request as ready for review
July 8, 2023 02:12
Member
Author
|
@kunalspathak, any other feedback or is this good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #83316