[mono][jit] Don't truncate the high bits when ldelema index is nint#88986
Merged
Conversation
BrzVlad
requested review from
SamMonoRT,
kotlarmilos,
lambdageek and
vargaz
as code owners
July 17, 2023 08:52
BrzVlad
marked this pull request as draft
July 18, 2023 10:38
BrzVlad
force-pushed
the
fix-nindex-out-of-range
branch
from
July 18, 2023 11:08
bb70d35 to
dc40a67
Compare
This was referenced Jul 19, 2023
BrzVlad
marked this pull request as ready for review
July 19, 2023 13:37
Member
Author
|
A little bit of complication because, according to comments, emitting the SEXT_I4 normally would interfere with bounds check removal. @vargaz Please take a look |
Previous code was assuming index is i4. Remove MONO_ARCH_EMIT_BOUNDS_CHECK on amd64 since it was doing a I4 comparison, while the index reg is i8. Use MONO_EMIT_DEFAULT_BOUNDS_CHECK instead also on amd64. On llvm we might not be able to insert the sign extending because it apparently interferes with abcrem optimization. We therefore split OP_BOUNDS_CHECK into two separate opcodes, so, after abcrem, we know whether we have to insert the sext or not.
Fix passing of i4 to wrapper accepting native int. The wrapper no longer does the sign extend in order to not lose high bits of native int.
BrzVlad
force-pushed
the
fix-nindex-out-of-range
branch
from
August 22, 2023 14:36
f92e772 to
caf60c0
Compare
Member
Author
|
@vargaz Could I have a review on this ? |
vargaz
reviewed
Sep 6, 2023
vargaz
approved these changes
Sep 6, 2023
vargaz
reviewed
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIT only fix from #73799. Interp fix might be more invasive.