Skip to content

Bring back CopyOutputSymbolsToPublishDirectory - #92315

Merged
agocke merged 2 commits into
dotnet:mainfrom
agocke:bring-back-copysymbols
Sep 20, 2023
Merged

agocke merged 2 commits into
dotnet:mainfrom
agocke:bring-back-copysymbols

Conversation

@agocke

@agocke agocke commented Sep 20, 2023

Copy link
Copy Markdown
Member

I accidentally removed this property from AOT compilation when adding support for Mac dsym bundles. This change re-enables support for suppressing debugging symbols in the output.

Fixes #92188

I accidentally removed this property from AOT compilation
when adding support for Mac dsym bundles. This change re-enables
support for suppressing debugging symbols in the output.

Fixes dotnet#92188
@ghost

ghost commented Sep 20, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

I accidentally removed this property from AOT compilation when adding support for Mac dsym bundles. This change re-enables support for suppressing debugging symbols in the output.

Fixes #92188

Author: agocke
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

Comment thread src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets Outdated
…e.Publish.targets

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@agocke
agocke merged commit c0b5150 into dotnet:main Sep 20, 2023
@agocke
agocke deleted the bring-back-copysymbols branch September 20, 2023 19:46
@agocke

agocke commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

/backport to release/8.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6253370170

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CopyOutputSymbolsToPublishDirectory is not respected

3 participants