Skip to content

[release/8.0] Adjust System.Net metrics for OTel conformance and consistency#93414

Merged
carlossanlop merged 5 commits into
dotnet:release/8.0from
antonfirsov:adjust-System.Net-metrics-backport
Oct 13, 2023
Merged

[release/8.0] Adjust System.Net metrics for OTel conformance and consistency#93414
carlossanlop merged 5 commits into
dotnet:release/8.0from
antonfirsov:adjust-System.Net-metrics-backport

Conversation

@antonfirsov

@antonfirsov antonfirsov commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Fixes #92956, fixes #92917, fixes #92837, fixes #93302

Backport of PRs #93255, #93254, #93322

Customer Impact

OpenTelemetry metrics is a new feature in .NET 8.0.
There are minor semantic aspects which are either not conforming to the OpenTelemetry standard (#92956, #92917), inconsistent with ASP.NET (#93302) or highly undesirable (#92837). Fixing these problems in .NET 9.0 would be a breaking change against 8.0, while implementing them in 8.0 GA has a much lower negative impact on customers.

Testing

Target test cases were added.

Risk

Low. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.

@ghost ghost added the area-System.Net.Http label Oct 12, 2023
@ghost ghost assigned antonfirsov Oct 12, 2023
@ghost

ghost commented Oct 12, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Adjust System.Net metrics for OTel conformance and consistency

Fixes #92956, fixes #92917, fixes #92837, fixes #93302

Backport of PRs #93255, #93254, #93322

Customer Impact

OpenTelemetry metrics is a new feature in .NET 8.0.
There are minor semantic aspects which are either not conforming to the OpenTelemetry standard (#92956, #92917), inconsistent with ASP.NET (#93302) or highly undesirable (#92837). Fixing these problems in .NET 9.0 would be a breaking change against 8.0, while implementing them in 8.0 GA has a much lower negative impact on customers.

Testing

Target test cases were added.

Risk

Low. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov antonfirsov added this to the 8.0.0 milestone Oct 12, 2023
@antonfirsov antonfirsov added the Servicing-consider Issue for next servicing release review label Oct 12, 2023
@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
antonfirsov requested a review from JamesNK October 12, 2023 20:18
@ghost

ghost commented Oct 12, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #92956, fixes #92917, fixes #92837, fixes #93302

Backport of PRs #93255, #93254, #93322

Customer Impact

OpenTelemetry metrics is a new feature in .NET 8.0.
There are minor semantic aspects which are either not conforming to the OpenTelemetry standard (#92956, #92917), inconsistent with ASP.NET (#93302) or highly undesirable (#92837). Fixing these problems in .NET 9.0 would be a breaking change against 8.0, while implementing them in 8.0 GA has a much lower negative impact on customers.

Testing

Target test cases were added.

Risk

Low. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.

Author: antonfirsov
Assignees: antonfirsov
Labels:

Servicing-consider, area-System.Net, area-System.Net.Http

Milestone: 8.0.0

@antonfirsov

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 13, 2023
@carlossanlop

Copy link
Copy Markdown
Contributor

Approved by Tactics via email.

@carlossanlop

Copy link
Copy Markdown
Contributor

The CI failures are unrelated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants