[NativeAOT] Support library mode with NativeAOT on iOS-like platforms - #93658

Merged

ivanpovazan merged 6 commits into

dotnet:mainfrom

ivanpovazan:naot-ios-libmode

Jan 10, 2024

ivanpovazan commented Oct 18, 2023 •

edited

Loading

Member

This PR enables support for building libraries for iOS-like platforms with NativeAOT.

Changes

Extended NativeAOT build integration targets to support building libraries for iOS-like platforms
Adapted AppleAppBuilder to support bundling in library mode for both MonoAOT and NativeAOT
Adapted AppleAppBuilder to support bundling in library mode when targeting iOS-like devices
Adapted src/tests/FunctionalTests/iOS/Simulator/LibraryMode for testing the library mode on iossimulators-arm64/x64 with NativeAOT - currently this only works locally please see comments in the project file for more info
- [NativeAOT] Enable running libraries and functional tests locally and on CI #93447)
Added src/tests/FunctionalTests/iOS/Device/LibraryMode for testing the library mode on ios-arm64 for both MonoAOT and NativeAOT

Additional notes

To test locally one can execute the following from the repo root directory:

Test MonoAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:RuntimeFlavor=Mono

Test NativeAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:UseNativeAOTRuntime=true /p:RunAOTCompilation=false /p:RuntimeFlavor=CoreCLR

Documentation

[ios][docs] Document how iOS library mode is supported #96742

Fixes #88737

ivanpovazan requested review from akoeplinger, filipnavara, jkotas and steveisok

October 18, 2023 12:02

ivanpovazan self-assigned this

ivanpovazan requested review from MichalStrehovsky and marek-safar as code owners

October 18, 2023 12:02

ghost added the area-Infrastructure-mono label

ivanpovazan requested a review from rolfbjarne

October 18, 2023 12:03

ghost commented Oct 18, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR enables support for building libraries for iOS-like platforms with NativeAOT.

Changes

Extended NativeAOT build integration targets to support building libraries for iOS-like platforms
Adapted AppleAppBuilder to support bundling in library mode for both MonoAOT and NativeAOT
Adapted AppleAppBuilder to support bundling in library mode when targeting iOS-like devices
Adapted src/tests/FunctionalTests/iOS/Simulator/LibraryMode for testing the library mode on iossimulators-arm64/x64 with NativeAOT - currently this only works locally please see comments in the project file for more info
- [NativeAOT] Enable running libraries and functional tests locally and on CI #93447)
Added src/tests/FunctionalTests/iOS/Device/LibraryMode for testing the library mode on ios-arm64 for both MonoAOT and NativeAOT

Additional notes

To test locally one can execute the following from the repo root directory:

Test MonoAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:RuntimeFlavor=Mono

Test NativeAOT library mode on ios-arm64:

./dotnet.sh build /t:Test -c Debug /p:TargetOS=ios /p:TargetArchitecture=arm64 src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj /p:UseNativeAOTRuntime=true /p:RunAOTCompilation=false /p:RuntimeFlavor=CoreCLR

Fixes #88737

Author:	ivanpovazan
Assignees:	ivanpovazan
Labels:	`area-Infrastructure-mono`
Milestone:	-

rolfbjarne reviewed

View reviewed changes

src/tasks/AppleAppBuilder/Xcode.cs Outdated

ivanpovazan commented Oct 18, 2023 •

edited

Loading

Member Author

~~Failures are related:~~
~~1. Since I introduced VerifyOSSpecificTooling target, it seems I broke some dependency with tooling in the build~~
~~2. Building on Helix for the library mode tests seem to be broken~~

build-analysis Bot mentioned this pull request

[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669

Closed

ivanpovazan commented Oct 18, 2023

Member Author

/azp run runtime-ioslikesimulator

azure-pipelines Bot commented Oct 18, 2023

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky reviewed

View reviewed changes

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets Outdated

ivanpovazan force-pushed the naot-ios-libmode branch from 5089847 to 2f65e3b Compare

October 20, 2023 11:51

build-analysis Bot mentioned this pull request

Tracking issue for CI build timeouts #76454

Closed

ivanpovazan mentioned this pull request

[helix][ios] Emulate deep signing of iOS app bundles on helix in order to support library mode builds dotnet/arcade#14164

Merged

ivanpovazan force-pushed the naot-ios-libmode branch from 43f2655 to 9ef633d Compare

November 13, 2023 21:44

ivanpovazan commented

View reviewed changes

global.json Outdated

ivanpovazan commented Nov 13, 2023

Member Author

/azp run runtime-ioslikesimulator

ivanpovazan commented Nov 13, 2023

Member Author

/azp run runtime-ioslike

azure-pipelines Bot commented Nov 13, 2023

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines Bot commented Nov 13, 2023

Azure Pipelines successfully started running 1 pipeline(s).

ivanpovazan commented Nov 13, 2023

Member Author

/azp run runtime-ioslikesimulator

azure-pipelines Bot commented Nov 13, 2023

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 14, 2023

Several XML tests are sporadically failing in CI due to OOMs #82894

Closed

[wasm] Runtime tests' build gets terminated with exited with code 137 #94077

Closed

Tracking issue for "WORKLOAD TIMED OUT" #90309

Closed

ivanpovazan requested review from MichalStrehovsky, akoeplinger, am11 and steveisok

December 22, 2023 09:29

am11 approved these changes

View reviewed changes

am11 left a comment

Member

Two optional nits, otherwise looks great! 👍

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets Outdated

src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj Outdated

runfoapp Bot mentioned this pull request

system.text.regularexpressions.tests work item #72834

Open

This was referenced Dec 22, 2023

Android emulator not booting completely on Helix queue dotnet/dnceng#1448

Closed

System.Tests.StringTests failing on windows Release NativeAOT_Libraries leg #96279

Closed

ivanpovazan commented Jan 8, 2024

Member Author

/azp run runtime-extra-platforms

azure-pipelines Bot commented Jan 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

build-analysis Bot mentioned this pull request

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests #92467

Closed

ivanpovazan added 6 commits

January 8, 2024 17:18


          Support library mode with NativeAOT on iOS-like platforms

e4cd60a


          PR feedback


          Simplifications according to the feedback

8262b02


          PR feedback

9d92eba


          PR feedback

3a7c402


          PR feedback

22235dd

ivanpovazan force-pushed the naot-ios-libmode branch from 17e5aed to 22235dd Compare

January 8, 2024 16:19

ivanpovazan commented Jan 8, 2024

Member Author

/azp run runtime-extra-platforms

azure-pipelines Bot commented Jan 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

ivanpovazan mentioned this pull request

[ios] Support bundling shared libraries into frameworks #96664

Closed

ivanpovazan commented Jan 9, 2024

Member Author

The CI failures are unrelated.

@steveisok @rolfbjarne @jkotas could you please take another look as we would like to get this in for net9.0-p1?

rolfbjarne approved these changes

View reviewed changes

rolfbjarne left a comment

Member

LGTM

akoeplinger approved these changes

View reviewed changes

jkotas commented Jan 9, 2024

Member

@jkotas could you please take another look as we would like to get this in for net9.0-p1?

The changes in the shared native AOT files LGTM.

MichalStrehovsky reviewed

View reviewed changes

MichalStrehovsky left a comment

Member

nativeaot/BuildIntegration looks good to me too!

ivanpovazan merged commit 3f3af5e into dotnet:main

ivanpovazan deleted the naot-ios-libmode branch

January 10, 2024 08:57

tmds pushed a commit to tmds/runtime that referenced this pull request


          [NativeAOT] Support library mode with NativeAOT on iOS-like platforms (…

9eca186

…dotnet#93658)

Fixes dotnet#88737

github-actions Bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

+2 more reviewers

Labels

area-Infrastructure-mono