Skip to content

[MT][browser] Disabling tests failing in the last two weeks on MT.#94051

Merged
ilonatommy merged 7 commits into
dotnet:mainfrom
ilonatommy:block-failing-mt
Oct 31, 2023
Merged

[MT][browser] Disabling tests failing in the last two weeks on MT.#94051
ilonatommy merged 7 commits into
dotnet:mainfrom
ilonatommy:block-failing-mt

Conversation

@ilonatommy

@ilonatommy ilonatommy commented Oct 26, 2023

Copy link
Copy Markdown
Member

Continuation of #93224.

Why do we remove test disabling and increase the thread for it instead:
Failure of type: #91549 is caused by too small thread pool size in the browser, so we could avoid it by increasing it.

 System.Threading.Tasks.TaskSchedulerException : An exception was thrown by a TaskScheduler.
info: ---- System.Threading.ThreadStartException : Thread failed to start.
info: -------- System.ExecutionEngineException : mono_thread_platform_create_thread() failed
info:    at System.Threading.Tasks.Task.ScheduleAndStart(Boolean needsProtection)
info:    at System.Threading.Tasks.Task.Start(TaskScheduler scheduler)
info:    at System.Threading.Tasks.Task.Start()
info:    at System.Threading.Tasks.Tests.TaskPropertiesTests.TaskOptionTest(Boolean runSync)
info:    at System.Threading.Tasks.Tests.TaskPropertiesTests.TaskOptionsTestAsync()
info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
info:    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
info: ----- Inner Stack Trace -----
info:    at System.Threading.Thread.ThrowThreadStartException(Exception ex)
info:    at System.Threading.Thread.StartCore()
info:    at System.Threading.Thread.Start(Object parameter, Boolean captureContext, Boolean internalThread)
info:    at System.Threading.Thread.UnsafeStart(Object parameter)
info:    at System.Threading.Tasks.ThreadPoolTaskScheduler.QueueTask(Task task)
info:    at System.Threading.Tasks.TaskScheduler.InternalQueueTask(Task task)
info:    at System.Threading.Tasks.Task.ScheduleAndStart(Boolean needsProtection)
info: ----- Inner Stack Trace -----

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue area-VM-threading-mono labels Oct 26, 2023
@ghost

ghost commented Oct 26, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Continuation of #93224.

Author: ilonatommy
Assignees: -
Labels:

arch-wasm, disabled-test, area-VM-threading-mono

Milestone: -

@ghost ghost assigned ilonatommy Oct 26, 2023
@ilonatommy

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
ilonatommy requested a review from radical October 30, 2023 10:16
@radical

radical commented Oct 30, 2023

Copy link
Copy Markdown
Member

cc @pavelsavara for review of the property value change.

@ilonatommy
ilonatommy merged commit 5df92ec into dotnet:main Oct 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-VM-threading-mono disabled-test The test is disabled in source code against the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants