JIT: Remove dead GT_NOP code in LSRA#94409
Merged
Merged
Conversation
Rationalization removes all GT_NOP nodes, and we do not seem to introduce any of these before LSRA (and especially not the typed "passthrough" GT_NOP nodes). This code is just wrong for the passthrough nodes, so just switch all the LSRA code to only handle potential void NOPs. Fix dotnet#93048
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsRationalization removes all GT_NOP nodes, and we do not seem to introduce any of these before LSRA (and especially not the typed "passthrough" GT_NOP nodes). This code is just wrong for the passthrough nodes, so just switch all the LSRA code to only handle potential void NOPs. Fix #93048
|
This was referenced Nov 6, 2023
jakobbotsch
marked this pull request as ready for review
November 6, 2023 19:08
Member
Author
|
cc @dotnet/jit-contrib PTAL @kunalspathak No diffs. Some TP improvements on linux-x64, not sure what's up with that -- I guess Clang changed codegen strategy in some way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationalization removes all GT_NOP nodes, and we do not seem to introduce any of these before LSRA (and especially not the typed "passthrough" GT_NOP nodes). This code is just wrong for the passthrough nodes, so just switch all the LSRA code to only handle potential void NOPs.
Fix #93048