Skip to content

[wasm][debugger] CI was broken for wasm debugger tests #99824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 9 commits into from
Mar 18, 2024
Merged

[wasm][debugger] CI was broken for wasm debugger tests #99824

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e5724b3
Use \e instead of \u001B or \x1B
stephentoub Mar 13, 2024
e397282
Suppress System.Threading.Lock cast to object errors
stephentoub Mar 13, 2024
66e230d
fix test failing
thaystg Mar 15, 2024
3e96c97
removing unrelated file
thaystg Mar 15, 2024
7f1bdf3
Revert "Use \e instead of \u001B or \x1B"
thaystg Mar 15, 2024
500c9fa
Revert "Suppress System.Threading.Lock cast to object errors"
thaystg Mar 15, 2024
3bdb774
Merge branch 'dotnet:main' into dev/thays/fixCi
thaystg Mar 15, 2024
addb460
adding stringcomparison.ordinal
thaystg Mar 15, 2024
58c2cf4
Merge branch 'dev/thays/fixCi' of github.com:thaystg/runtime into dev…
thaystg Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mono/browser/debugger/DebuggerTestSuite/BreakpointTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ await EvaluateAndCheck(

foreach (var frame in pause_location["callFrames"])
{
Assert.Equal(false, frame["url"].Value<string>().Contains(".wasm"));
Assert.Equal(false, frame["url"].Value<string>().EndsWith(".wasm", StringComparison.Ordinal));
Assert.Equal(false, frame["url"].Value<string>().Contains("wasm://"));
}
return Task.CompletedTask;
Expand Down