Add VB FileCleanupTestsBase plus dependent tests REVIEW FIRST - #11987
Merged
lonitra merged 167 commits intoSep 18, 2024
Conversation
Add Tests for ExceptionUtils
Remove unneeded Paentheses Cleanup spacing Sort UnsafeNativeMethods
Add tests for FileIOProxy and FileLogTraceListenerTests to use new base class
paul1956
marked this pull request as ready for review
September 14, 2024 01:25
Fix parameter names in VbFileCleanupTestBase to better reflect usage
Contributor
Author
|
@Tanya-Solyanik I also realized the name of the file and class for FileIoProxyTests is wrong, it should be FileSystemProxyTests. I renamed it. |
Remove all redundant VB tests
| /// Returns the <see href="https://learn.microsoft.com/windows/win32/api/winuser/nf-winuser-getkeyboardlayoutnamew"> | ||
| /// Returns the | ||
| /// <see href="https://learn.microsoft.com/windows/win32/api/winuser/nf-winuser-getkeyboardlayoutnamew"> | ||
| /// keyboard layout identifier</see> of the current input language. |
Member
There was a problem hiding this comment.
I think this better follows the pattern of the other see tags in the source code:
/// <summary>
/// Returns the
/// <see href="https://learn.microsoft.com/windows/win32/api/winuser/nf-winuser-getkeyboardlayoutnamew">
/// keyboard layout identifier
/// </see>
/// of the current input language.
/// </summary>
Contributor
Author
There was a problem hiding this comment.
@ricardobossan The will be addressed in a separate PR #12151 I opened. This one already has too many changes unrelated to the to FileCleanupTestBase. #12151 just addresses "See href" based on Main. That could be merged before or after this one.
lonitra
reviewed
Sep 16, 2024
…ccessibiltyExtensions.cs Co-authored-by: Loni Tra <lonitra@microsoft.com>
lonitra
previously approved these changes
Sep 16, 2024
Contributor
Author
|
@lonitra I will open a new issue on AccessibilityExtensions spelling. |
Contributor
Author
|
@lonitra anything preventing merge? Do I still need to fix spelling issue here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11031 by adding more tests
Proposed changes
Add more tests to VB Runtime
This also adds a new test class to provide cleaner file cleanup, that is different than what C# provides in FileCleanupTestBase, this class will get additional functionality in another PR.
Customer Impact
Improve code quality
Regression?
Risk
None just adds tests
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow