Merging version bumps from last Bioc release and updating GHA - #148
Merged
Merged
Conversation
Collaborator
Author
|
Looks like the GitHub Actions checks error is due to the package files exceeding 5 MB, which gets flagged by BiocCheck. I believe this is only an error for initial submission, not updates, so should be ok. |
Collaborator
Author
|
In fact looking at my commit above to update the GitHub Actions workflow (5fcc22c), we had previously commented out BiocCheck, presumably for this same reason. I'll re-comment it out again to avoid this error. |
drighelli
approved these changes
Mar 18, 2024
Owner
|
is this solved now? It seems so to me! Thanks! |
Collaborator
Author
|
Great, thanks for approving. I'll merge this and push the version bumps to upstream / Bioc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR merges the version bumps from the last Bioc release cycle and updates the GitHub Actions workflow to the latest Bioc versions. Once this is merged into GitHub
develbranch we can re-synchronize GitHub /originand Bioc /upstream.