Refactor split projects - #6
Merged
Merged
Conversation
drmoisan
added a commit
that referenced
this pull request
Mar 11, 2026
…same process Root cause of CI #6 failure: Out-File in PowerShell uses UTF-16 encoding by default. GitHub Actions reads GITHUB_ENV as UTF-8, so CI_CERT_THUMBPRINT was never parsed correctly. MSBuild received an empty thumbprint, triggering the 'cannot find certificate' error. Fix: - Directory.Build.targets: scope SetTaskMasterManifestCert to non-CI builds (added 'and $(CI) != rue' to the Target condition). A target-scoped PropertyGroup runs at execution time and would override a command-line /p:ManifestCertificateThumbprint value, so the target must not run in CI. Developer builds are unchanged. - ci.yml: remove the standalone cert-gen step that relied on GITHUB_ENV. Instead, create the ephemeral self-signed certificate and invoke MSBuild in the same PowerShell process for both build steps. The thumbprint stays in a local variable with no inter-step transfer, eliminating the encoding issue entirely. The nullable build step looks up the cert by subject so it does not need to create a second certificate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored all code to split functionality into distinct projects. Also removed ObjectListView code and connected a reference due to bugs in the migration of dot.net target framework