chore(oomph): pin the workspace line delimiter to LF#1478
Open
joaodinissf wants to merge 1 commit into
Open
Conversation
The repository stores and checks out LF everywhere (.gitattributes, line-endings CI check, project-scoped line.separator settings), and the generation pipelines emit LF deterministically. The one remaining platform-dependent default is the workspace-level Eclipse preference: on a fresh Windows workspace, "New text file line delimiter" falls back to the platform separator (CRLF), so anything created outside the project-scoped settings — and any Xtext IDE generation resolving the workspace preference — can still churn against the LF checkout. Provision /instance/org.eclipse.core.runtime/line.separator = "\n" in the Oomph product setup so every DDK Eclipse starts with a Unix line delimiter workspace-wide. The value is an XML character reference so attribute normalization preserves the newline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
joaodinissf
marked this pull request as ready for review
July 23, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds one Oomph
PreferenceTaskto the DDK Eclipse product setup:/instance/org.eclipse.core.runtime/line.separator= LF, so every provisioned workspace starts with a Unix line delimiter workspace-wide. (The value is an XML character reference,
, so XML attribute normalization preserves the newline.)Why
This closes the last platform-dependent line-ending default. The repo already enforces LF at every other layer:
.gitattributes+ the line-endings CI check (storage/checkout), project-scopedline.separatorsettings linked fromddk-configuration(#1413), LF from the MWE2 code-generation workflows (#1413), and deterministic LF from the headless generation pipelines (#1477). The remaining hole: on a fresh Windows workspace the Eclipse workspace preference falls back to the platform separator (CRLF) — so files created outside the project-scoped settings, and IDE-side Xtext generation resolving the workspace preference, can still be written CRLF and churn against the LF checkout (rewrites → rebuild pressure → the Windows build-performance symptoms).With this task, a fresh Oomph-provisioned DDK workspace is LF end-to-end: storage, checkout, headless generation, IDE generation, and new files.
Verification
xmllint --nooutpasses on the edited setup.CompoundTaskstructure inDDKEclipse.setup(same pattern as theorg.eclipse.core.resourcesandorg.eclipse.ui.editorstasks).🤖 Generated with Claude Code