ci: pin the dx CLI to a build that can read plugin configs - #28
Merged
Conversation
The pinned preview (4fb6037) predates dxos/dxos#12513–#12514: its loadDxConfig resolves esbuild from inside the compiled binary's embedded filesystem, so `dx registry publish` dies before reading a single config field. ba08e65 evaluates the config in a node subprocess instead, verified against this repo's tictactoe plugin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SZ4ZdaPo9erkh5yF4eXh3Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
DX_CLI_PACKAGEfallback from4fb6037toba08e65(current dxosmain).The pinned preview predates dxos/dxos#12513–#12514: its
loadDxConfigresolves esbuild from inside the compiled binary's embedded filesystem, sodx registry publishdies before reading a single config field — which is exactly where the lastregistry_onlydispatch failed.ba08e65evaluates the config in anodesubprocess; verified locally against this repo's tictactoe plugin (config loads and decodes; the run proceeds to the ATProto request).Once this lands, dispatching Release with
registry_only: trueis the first credentialed test of the registry publish.Generated by Claude Code