orchestrator/pkg/template/metadata fails to compile on non-Linux (Darwin) after build tags removed

[evanmarshall]

What's wrong

PR #3299 removed the //go:build linux constraints from template_metadata.go and prefetch.go in packages/orchestrator/pkg/template/metadata, making those files eligible for non-Linux builds. But both still import github.com/e2b-dev/infra/packages/orchestrator/pkg/sandbox/block, and the block package is almost entirely Linux-only (range.go, cache.go, memfd.go, overlay.go, device.go, tracker.go, etc. all carry //go:build linux). Only prefetch_tracker.go supplies the shared data types.

As a result, GOOS=darwin builds of the metadata/prefetch packages fail: they import a package with no buildable Go files on Darwin. This blocks local development and tooling on macOS.

Where

• packages/orchestrator/pkg/template/metadata/template_metadata.go (imports sandbox/block, no build tag): https://github.com/e2b-dev/infra/blob/main/packages/orchestrator/pkg/template/metadata/template_metadata.go#L1-L15
• packages/orchestrator/pkg/template/metadata/prefetch.go (same import, no build tag): https://github.com/e2b-dev/infra/blob/main/packages/orchestrator/pkg/template/metadata/prefetch.go#L1-L11
• packages/orchestrator/pkg/sandbox/block/range.go still //go:build linux (representative of the package): https://github.com/e2b-dev/infra/blob/main/packages/orchestrator/pkg/sandbox/block/range.go#L1

How to reproduce

1. GOOS=darwin GOARCH=amd64 go build ./packages/orchestrator/pkg/template/metadata/...
2. Build fails because the imported sandbox/block package has no Go files buildable for Darwin.

Suggested fix

Separate the portable metadata/prefetch data types (e.g. PrefetchBlockEntry) from the Linux-only block implementation so the metadata package can compile cross-platform, or add a minimal non-Linux stub for the block package. If Darwin builds of this package aren't intended to be supported, restoring a build constraint on the metadata files would also resolve the mismatch.

Found while running Ito (AI code review, free for open source) against recently merged PRs — full analysis: https://app.ito.ai/share/dacb5bb0-ce18-415f-aa26-0c706e869d42.

[arkamar]

I cannot reproduce it, could it be because I run it on linux?

GOOS=darwin GOARCH=amd64 go build ./pkg/template/metadata/...   → exit 0
GOOS=darwin GOARCH=amd64 go build ./pkg/sandbox/block/          → exit 0
GOOS=darwin GOARCH=amd64 go vet   ./pkg/template/metadata/...   → exit 0
GOOS=darwin GOARCH=amd64 go build ./cmd/copy-build/             → exit 0

The claim that sandbox/block package has no Go files buildable for Darwin is also not true. ./pkg/sandbox/block/prefetch_tracker.go contains only OS agnostic code, which is needed in metadata.

[arkamar]

Checked on darwin and the GOOS=darwin GOARCH=amd64 go build ./packages/orchestrator/pkg/template/metadata/... seems to compile there fine.

Closing this as I couldn't replicate it.