Modify UFFD tests to run serve loop in a separate process - #1450
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ValentaTomas
marked this pull request as draft
November 6, 2025 23:50
ValentaTomas
marked this pull request as ready for review
November 7, 2025 01:09
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ValentaTomas
enabled auto-merge (squash)
November 7, 2025 02:12
djeebus
reviewed
Nov 7, 2025
djeebus
approved these changes
Nov 7, 2025
ValentaTomas
added a commit
that referenced
this pull request
May 2, 2026
…MissingWriteWithPrefault loads to 1_000_000 Continues the regression sweep started in 4681ab2. The original PR #1415 (88c3960, Nov 3 2025) introduced these tests at 1_000_000 operations. PR #1450 (6ee2ebb, Nov 7 2025, "Modify UFFD tests to run serve loop in a separate process") cut them all to 10_000 in the same commit that switched from in-process to cross-process tests, with no commit message justification. The cross-process refactor itself does not require lower iteration counts: the per-iteration work is still in-process memory access; only the page-state snapshot RPC is cross-process and is called once per test. Reverts: - TestSerialMissing: 10_000 -> 1_000_000 - TestSerialMissingWrite: 10_000 -> 1_000_000 - TestParallelMissingWriteWithPrefault: 10_000 -> 1_000_000 Per-test wall time on this branch (sudo go test, no -race): - TestSerialMissing ~3s - TestSerialMissingWrite ~3s - TestParallelMissingWriteWithPrefault ~2s TestParallelMissingWithPrefault stays at 10_000: it was only ever parallelOperations := 10 in #1415, then bumped to 10_000 in #1450, so 10_000 is already above its historical baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This more accurately simulates the FC-orchestrator configuration and prevents the Go mmap bugs.
Note
Run the UFFD serve loop in a helper process with pipe/signal IPC, refactor tests to use cross-process flow, and update test utilities to new APIs.
configureCrossProcessTestand helperTestHelperServingProcessto serve page faults in a separate process using pipes (content, offsets, ready) and signals (SIGUSR1/SIGUSR2).missing_test.goandmissing_write_test.go; addt.Parallel()and adjust operation counts; change some hugepage suites tonumberOfPages: 8.offsetsOnce().cross_process_helper_test.go: implements cross-process serving (crossProcessServe), offset collection (getAccessedOffsets), and IPC setup; usesfdexit,mapping, andzaplogger.testHandler: remove in-processmissingRequests/mapping; addoffsetsOnceand a writemutex; droptouchRead.NewMemorySlicerand addSize()/Content()methods; updateRandomPagesto use it.NewPageMmapAPI to accept*testing.Tand manage cleanup internally; remove explicit unmap return value.Written by Cursor Bugbot for commit d17d851. This will update automatically on new commits. Configure here.