Skip to content

Tweak bot PR review prompts - #1465

Merged
ValentaTomas merged 4 commits into
mainfrom
review-tweaks
Nov 10, 2025
Merged

ValentaTomas merged 4 commits into
mainfrom
review-tweaks

Conversation

@ValentaTomas

@ValentaTomas ValentaTomas commented Nov 8, 2025 •

Copy link
Copy Markdown
Member

Note

Adds BugBot config and tightens Claude Code Review workflow to trigger only on opened PRs with stricter, inline-comment guidance using gh api.

  • CI/Workflows:
    • Update /.github/workflows/claude-code-review.yml to trigger only on pull_request: [opened].
    • Expand review prompt with stricter guidance: avoid summaries, reduce false positives, and post issues only as inline comments using gh api with the provided payload format.
    • Adjust claude_args to allow gh api while keeping other gh commands.
  • Tooling/Config:
    • Add /.cursor/BUGBOT.md with concise rules for PR descriptions and reviews.

Written by Cursor Bugbot for commit b49f9a7. This will update automatically on new commits. Configure here.

@ValentaTomas

Copy link
Copy Markdown
Member Author
  • The Claude review test seems to fail because of the difference in the workflows with main
  • The integration test failure is a flake

Comment thread .cursor/BUGBOT.md
Comment thread .github/workflows/claude-code-review.yml Outdated
Comment thread .cursor/BUGBOT.md
@ValentaTomas
ValentaTomas requested a review from djeebus November 9, 2025 19:05

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Forbidden Action: Permission Mismatch

The workflow instructs Claude to post inline comments using gh api to create PR review comments, but the permissions block only grants pull-requests: read. Posting comments via the GitHub API requires pull-requests: write permission, causing the workflow to fail with a 403 Forbidden error when attempting to post comments.

.github/workflows/claude-code-review.yml#L11-L16

https://github.com/e2b-dev/infra/blob/c919c3ab0882f85ecd6c086a7129c9e949440080/.github/workflows/claude-code-review.yml#L11-L16

Fix in Cursor Fix in Web


@ValentaTomas

ValentaTomas commented Nov 9, 2025 •

Copy link
Copy Markdown
Member Author

Bug: Forbidden Action: Permission Mismatch

The workflow instructs Claude to post inline comments using gh api to create PR review comments, but the permissions block only grants pull-requests: read. Posting comments via the GitHub API requires pull-requests: write permission, causing the workflow to fail with a 403 Forbidden error when attempting to post comments.

.github/workflows/claude-code-review.yml#L11-L16
https://github.com/e2b-dev/infra/blob/c919c3ab0882f85ecd6c086a7129c9e949440080/.github/workflows/claude-code-review.yml#L11-L16

Fix in Cursor Fix in Web

Previously, it was able to post normal comments with these permissions, so I think the permissions are granted by the Claude GH App.

@jakubno

jakubno commented Nov 10, 2025

Copy link
Copy Markdown
Member

Can we merge this soon, claude is suuuuuper annoying

Comment thread .cursor/BUGBOT.md Outdated
Comment thread .github/workflows/claude-code-review.yml
@ValentaTomas
ValentaTomas merged commit acb8f0c into main Nov 10, 2025
24 checks passed
@ValentaTomas
ValentaTomas deleted the review-tweaks branch November 10, 2025 18:09
on:
pull_request:
types: [opened, synchronize]
types: [opened]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Comments: Permissions Denied

The workflow instructs Claude to post inline PR comments using gh api to create review comments, but the permissions only grant pull-requests: read. Creating PR review comments via the GitHub API requires pull-requests: write permission, causing the workflow to fail with a 403 Forbidden error when attempting to post comments.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants