Conversation
sitole
approved these changes
Dec 8, 2025
jakubno
deleted the
forward-sandbox-metrics-from-byoc-clickhouse-through-edge-eng-3373
branch
December 8, 2025 16:29
arkamar
added a commit
that referenced
this pull request
Jul 1, 2026
This flag was a temporary migration toggle from #1588 for the sandbox-metrics read path. The consuming code was removed in 9cc1504 ("Make edge api optional for OSS deployment", #1638), which collapsed onto a single cluster resource provider but left this declaration behind as dead code. No references remain. Link: #1638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds edge-backed retrieval for sandbox metrics (single and list) gated by a feature flag, with ClickHouse fallback and improved flag context/error handling.
EdgeProvidedSandboxMetricsFlagNameto choose metrics source.GetSandboxesSandboxIDMetricsandGetSandboxesMetrics, route to edge clients when enabled; otherwise use ClickHouse.getApiProvidedMetrics,getApiProvidedSandboxListMetrics) returningapi.APIError; adjust logging and responses.packages/api/internal/edge/metrics.go):GetClusterSandboxMetricsandGetClusterSandboxListMetricscalling edge HTTP APIs and mapping toapi.SandboxMetric.EdgeProvidedSandboxMetricsFlagName(edge-provided-sandbox-metrics) and register in LaunchDarkly offline store.Written by Cursor Bugbot for commit 8dd48bc. This will update automatically on new commits. Configure here.