Skip storing sandbox routing to Redis if sandbox is in remote cluster - #1765
Merged
sitole merged 3 commits intoJan 23, 2026
Merged
Conversation
sitole
marked this pull request as ready for review
January 23, 2026 12:25
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e756098ec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jakubno
approved these changes
Jan 23, 2026
Co-authored-by: Jakub Novák <jakub@e2b.dev>
sitole
enabled auto-merge (squash)
January 23, 2026 14:34
sitole
deleted the
fix/stop-exposing-sandobx-routing-for-remote-clusters
branch
January 23, 2026 14:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1763 (comment)
Note
Focus routing-table updates to Nomad-managed nodes only.
lifecycle.go,addSandboxToRoutingTablenow returns early if node is nil and skips RedisStoreSandboxunlessnode.IsNomadManaged(); remote clusters rely on gRPC metadata insteaddelete_instance.go,removeSandboxFromNodenow deletes from routing catalog only whennode.IsNomadManaged()Written by Cursor Bugbot for commit 2ab0808. This will update automatically on new commits. Configure here.