Skip to content

feat(api): make Nomad node pool configurable - #2368

Closed
chencjcj wants to merge 1 commit into
e2b-dev:mainfrom
chencjcj:feat/configurable-nomad-node-pool
Closed

chencjcj wants to merge 1 commit into
e2b-dev:mainfrom
chencjcj:feat/configurable-nomad-node-pool

Conversation

@chencjcj

Copy link
Copy Markdown
Contributor

Summary

The Nomad node pool name is currently hardcoded as "default" in the API's orchestrator client . This PR makes it configurable via the NOMAD_NODE_POOL environment variable, enabling deployments that use custom Nomad node pools.

Changes

  • Add NomadNodePool config field (NOMAD_NODE_POOL env var, defaults to "default")
  • Replace hardcoded "default" pool filter in listNomadNodes with the configurable value
  • Pass NOMAD_NODE_POOL from Terraform (var.orchestrator_node_pool) to the API job in both GCP and AWS providers
  • Update tests to include the new field

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@ValentaTomas ValentaTomas removed their assignment May 1, 2026
@ValentaTomas
ValentaTomas removed their request for review May 1, 2026 19:54
@chencjcj

chencjcj commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

@dobrac friendly ping — would appreciate your review when you have time. Thanks!

@jakubno

jakubno commented Jul 9, 2026

Copy link
Copy Markdown
Member

@chencjcj , thanks for you contribution, but this is currently being reworked and we're moving to different kind of nomad discovery. That should fix this as well (#3176)

@jakubno jakubno closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants