Skip to content

fix(api): downgrade team-limit build errors to warnings and dedupe logs #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakubno merged 3 commits into from
May 13, 2026
Merged

fix(api): downgrade team-limit build errors to warnings and dedupe logs #2635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68fbd39
fix(api): downgrade team-limit build errors to warnings and dedupe logs
jakubno May 13, 2026
ebb13a1
Update packages/api/internal/handlers/template_request_build_v3.go
jakubno May 13, 2026
b39dd89
chore: address pr comments
jakubno May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/api/internal/handlers/deprecated_template_request_build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (a *APIStore) PostTemplates(c *gin.Context) {

template, apiErr := a.buildTemplate(ctx, userID, team, templateID, body)
if apiErr != nil {
telemetry.ReportCriticalError(ctx, "error when requesting template build", apiErr.Err, telemetry.WithTemplateID(templateID))
telemetry.ReportErrorByCode(ctx, apiErr.Code, "error when requesting template build", apiErr.Err, telemetry.WithTemplateID(templateID))
a.sendAPIStoreError(c, apiErr.Code, apiErr.ClientMsg)

return
Expand Down Expand Up @@ -130,7 +130,7 @@ func (a *APIStore) PostTemplatesTemplateID(c *gin.Context, rawTemplateID api.Tem

template, apiErr := a.buildTemplate(ctx, userID, team, templateID, body)
if apiErr != nil {
telemetry.ReportCriticalError(ctx, "error when requesting template build", apiErr.Err, telemetry.WithTemplateID(templateID))
telemetry.ReportErrorByCode(ctx, apiErr.Code, "error when requesting template build", apiErr.Err, telemetry.WithTemplateID(templateID))
a.sendAPIStoreError(c, apiErr.Code, apiErr.ClientMsg)

return
Expand Down
2 changes: 1 addition & 1 deletion packages/api/internal/handlers/template_request_build_v3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func requestTemplateBuild(ctx context.Context, c *gin.Context, a *APIStore, body
template, apiError := template.RegisterBuild(ctx, a.templateCache, a.sqlcDB, buildReq)
if apiError != nil {
a.sendAPIStoreError(c, apiError.Code, apiError.ClientMsg)
telemetry.ReportCriticalError(ctx, "build template register failed", apiError.Err)
telemetry.ReportErrorByCode(ctx, apiError.Code, "error when requesting template build", apiError.Err, telemetry.WithTemplateID(templateID))

return nil
}
Expand Down
4 changes: 0 additions & 4 deletions packages/api/internal/template/register_build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,6 @@ func RegisterBuild(

cpuCount, ramMB, apiError := team.LimitResources(data.Team.Limits, data.CpuCount, data.MemoryMB)
if apiError != nil {
telemetry.ReportCriticalError(ctx, "error when getting CPU and RAM", apiError.Err)

return nil, apiError
}

Comment thread
jakubno marked this conversation as resolved.
Expand Down Expand Up @@ -257,7 +255,6 @@ func RegisterBuild(

if exists {
err := fmt.Errorf("alias '%s' is already used", alias)
telemetry.ReportCriticalError(ctx, "conflict of alias", err, attribute.String("alias", alias))

return nil, &api.APIError{
Err: err,
Expand Down Expand Up @@ -319,7 +316,6 @@ func RegisterBuild(
telemetry.ReportEvent(ctx, "created new alias", attribute.String("env.alias", alias))
} else if aliasDB.EnvID != data.TemplateID {
err := fmt.Errorf("alias '%s' already used", alias)
telemetry.ReportCriticalError(ctx, "alias already used", err, attribute.String("alias", alias))

return nil, &api.APIError{
Err: err,
Expand Down
Loading