Skip to content

feat(envd): add --no-cgroups flag to disable cgroup management #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvi merged 1 commit into from
May 25, 2026
Merged

feat(envd): add --no-cgroups flag to disable cgroup management #2811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/envd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ var (
versionFlag bool
commitFlag bool
cgroupRoot string
noCgroups bool
verbose bool
)

Expand Down Expand Up @@ -95,6 +96,13 @@ func parseFlags() {
"cgroup root directory",
)

flag.BoolVar(
&noCgroups,
"no-cgroups",
false,
"disable cgroup management; use a no-op cgroup manager instead",
)

flag.BoolVar(
&verbose,
"verbose",
Expand Down Expand Up @@ -236,6 +244,15 @@ func createCgroupManager() (m cgroups.Manager) {
}
}()

// Explicit opt-out: callers can tell envd to skip cgroup setup entirely.
// We return the no-op manager directly without touching /sys/fs/cgroup
// so we don't log spurious errors.
if noCgroups {
fmt.Fprintf(os.Stderr, "cgroups disabled via --no-cgroups; using no-op cgroup manager\n")

return cgroups.NewNoopManager()
}

metrics, err := host.GetMetrics()
if err != nil {
fmt.Fprintf(os.Stderr, "failed to calculate host metrics: %v\n", err)
Expand Down
Loading