Skip to content

fix(copy-build): resolve compression suffix for build data files #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkamar merged 1 commit into from
May 29, 2026
Merged

fix(copy-build): resolve compression suffix for build data files #2859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions packages/orchestrator/cmd/copy-build/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,28 +128,25 @@ func NewHeaderFromPath(ctx context.Context, from, headerPath string) (*header.He
return h, nil
}

func getReferencedData(h *header.Header, objectType storage.ObjectType) []string {
builds := make(map[string]struct{})
func getReferencedData(h *header.Header, dataFileName string) []string {
builds := make(map[uuid.UUID]struct{})

for _, mapping := range h.Mapping {
builds[mapping.BuildId.String()] = struct{}{}
builds[mapping.BuildId] = struct{}{}
}

delete(builds, uuid.Nil.String())
delete(builds, uuid.Nil)

var dataReferences []string

for build := range builds {
paths := storage.Paths{
BuildID: build,
BuildID: build.String(),
}

switch objectType {
case storage.MemfileHeaderObjectType:
dataReferences = append(dataReferences, paths.Memfile())
case storage.RootFSHeaderObjectType:
dataReferences = append(dataReferences, paths.Rootfs())
}
ct := h.GetBuildFrameData(build).CompressionType()
Comment thread
arkamar marked this conversation as resolved.

dataReferences = append(dataReferences, paths.DataFile(dataFileName, ct))
}

return dataReferences
Expand Down Expand Up @@ -246,7 +243,7 @@ func main() {
memfileHeader = h
}

dataReferences := getReferencedData(memfileHeader, storage.MemfileHeaderObjectType)
dataReferences := getReferencedData(memfileHeader, storage.MemfileName)

filesToCopy = append(filesToCopy, buildMemfileHeaderPath)
filesToCopy = append(filesToCopy, dataReferences...)
Expand All @@ -272,7 +269,7 @@ func main() {
rootfsHeader = h
}

dataReferences = getReferencedData(rootfsHeader, storage.RootFSHeaderObjectType)
dataReferences = getReferencedData(rootfsHeader, storage.RootfsName)

filesToCopy = append(filesToCopy, buildRootfsHeaderPath)
filesToCopy = append(filesToCopy, dataReferences...)
Expand Down
Loading