You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low Risk
Boot-time sysctl tuning only; slightly higher dirty memory use before throttling, with no auth or application logic changes.
Overview
Nomad client bootstrap now sets higher kernel dirty-page thresholds (vm.dirty_background_ratio and vm.dirty_ratio) so write-heavy workloads can accumulate more dirty memory before the kernel starts background or synchronous writeback throttling.
Reviewed by Cursor Bugbot for commit ecdac81. Bugbot is set up for automated code reviews on this repo. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Nomad client start script to configure larger host writeback bursts by setting vm.dirty_background_ratio and vm.dirty_ratio. There are no review comments or critical findings to report.
=== RUN TestSandboxMetrics
=== PAUSE TestSandboxMetrics
=== CONT TestSandboxMetrics
sandbox_metrics_test.go:26:
Error Trace: .../api/metrics/sandbox_metrics_test.go:26
Error: Condition never satisfied
Test: TestSandboxMetrics
Messages: sandbox metrics not available in time
--- FAIL: TestSandboxMetrics (18.70s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise client host dirty page thresholds so writeback-heavy workloads can keep more dirty data in flight before throttling.
Test plan
Not run; bootstrap sysctl-only change.