CLI(inspect-build): support V4/V5 headers, compression - #2985
Merged
Merged
Conversation
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
There was a problem hiding this comment.
Code Review
In packages/orchestrator/cmd/inspect-build/validate.go, the seekable object returned by OpenSeekable is leaked if subsequent initialization steps in openChunker fail before the chunker is successfully created. A deferred cleanup block should be introduced to close the object on any initialization failure.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Single render pipeline (HEADER / IMAGE / MAPPINGS / BUILDS / DATA / HEATMAP / METADATA) with a human TTY dashboard and JSON output. HEATMAP shows per-2MiB-chunk compression and cold-fetch fanout, mirroring block.Chunker.locateChunk. JSON is header-dump style: frame tables embedded under builds[], self carries fetches per frame. Flags: -build / -template / -storage / -memfile / -rootfs, -human / -json, -decimal, -expand=mappings,frames,metadata,all, -range=offset:size, -validate (fetch + decompress every frame via the production read path and verify checksum), -recursive (walk the ancestor chain). The pre-redesign header-dump tool is preserved in main.go behind --old; the new dispatcher lives at the top of main() and the new entry point is runInspect() in inspect.go.
levb
force-pushed
the
lev-compression-CLI
branch
from
June 11, 2026 18:14
b347d28 to
def98b7
Compare
levb
marked this pull request as ready for review
June 11, 2026 18:17
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: def98b7444
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e4cf50205
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ValentaTomas
approved these changes
Jun 11, 2026
levb
enabled auto-merge (squash)
June 11, 2026 19:58
ValentaTomas
added a commit
that referenced
this pull request
Jun 11, 2026
## Summary `TestRoundTrip` in `pkg/nfsproxy` fails intermittently with `bind: address already in use` (e.g. on [PR #2985](https://github.com/e2b-dev/infra/actions/runs/27373170636/job/80890489083)). The `go-nfs-client` library binds a random ephemeral local port when dialing and only retries `EADDRINUSE` collisions for privileged dials, so non-privileged dials flake on port collisions. Retry the dials in the test on `EADDRINUSE`.
ValentaTomas
added a commit
that referenced
this pull request
Jun 11, 2026
Main is broken: #2919 moved the upstream `Seekable` out of `block.NewChunker` and into `Chunker.Slice` (as a `storage.RangeOpener` param), and #2985 merged alongside it without picking up the new signatures, so `cmd/inspect-build` fails to compile (see [this run](https://github.com/e2b-dev/infra/actions/runs/27380475452/job/80915690448)). Updates `validate.go` to the new API: `openChunker` now also returns the storage object, which is passed to each `Slice` call — mirroring the production read path in `storage_diff.go`.
Piwriw
pushed a commit
to Piwriw/infra
that referenced
this pull request
Jun 12, 2026
## Summary `TestRoundTrip` in `pkg/nfsproxy` fails intermittently with `bind: address already in use` (e.g. on [PR e2b-dev#2985](https://github.com/e2b-dev/infra/actions/runs/27373170636/job/80890489083)). The `go-nfs-client` library binds a random ephemeral local port when dialing and only retries `EADDRINUSE` collisions for privileged dials, so non-privileged dials flake on port collisions. Retry the dials in the test on `EADDRINUSE`.
Piwriw
pushed a commit
to Piwriw/infra
that referenced
this pull request
Jun 12, 2026
Piwriw
pushed a commit
to Piwriw/infra
that referenced
this pull request
Jun 12, 2026
…ev#2989) Main is broken: e2b-dev#2919 moved the upstream `Seekable` out of `block.NewChunker` and into `Chunker.Slice` (as a `storage.RangeOpener` param), and e2b-dev#2985 merged alongside it without picking up the new signatures, so `cmd/inspect-build` fails to compile (see [this run](https://github.com/e2b-dev/infra/actions/runs/27380475452/job/80915690448)). Updates `validate.go` to the new API: `openChunker` now also returns the storage object, which is passed to each `Slice` call — mirroring the production read path in `storage_diff.go`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100% VIBE CODED but appears to display everything correctly.
Single render pipeline (HEADER / IMAGE / MAPPINGS / BUILDS / DATA / HEATMAP / METADATA) with a human TTY dashboard and JSON output. HEATMAP shows per-2MiB-chunk compression and cold-fetch fanout, mirroring block.Chunker.locateChunk. JSON is header-dump style: frame tables embedded under builds[], self carries fetches per frame.
Flags: -build / -template / -storage / -memfile / -rootfs, -human / -json, -decimal, -expand=mappings,frames,metadata,all, -range=offset:size, -validate (fetch + decompress every frame via the production read path and verify checksum), -recursive (walk the ancestor chain). Pre-redesign tool preserved behind
--old.