Skip to content

fix(orchestrator): log missing egress proxy in startup reclaim instead of defaulting silently #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wj-e2b merged 1 commit into from
Jun 27, 2026
Merged

fix(orchestrator): log missing egress proxy in startup reclaim instead of defaulting silently #3116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/orchestrator/pkg/startupreclaim/reclaim.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,16 @@ type reclaimer struct {

func Run(ctx context.Context, config Config) Summary {
config = config.withDefaults()

// No egress proxy wired: slots are still torn down, but the egress firewall
// cleanup (OnSlotDelete) is skipped and those iptables rules may leak. Log it
// instead of substituting silently; callers with no egress firewall can pass
// network.NewNoopEgressProxy() to opt in quietly.
if config.EgressProxy == nil {
logger.L().Error(ctx, "startup reclaim: no egress proxy provided; egress firewall cleanup will be skipped for reclaimed slots")
config.EgressProxy = network.NewNoopEgressProxy()
}

summary := Summary{Reclaimed: map[string]int{}, Failed: map[string]int{}}

// Order matters: firecracker runs first so the VMMs are killed before the
Expand Down Expand Up @@ -137,9 +147,6 @@ func (c Config) withDefaults() Config {
if c.CgroupRoot == "" {
c.CgroupRoot = cgroup.RootCgroupPath
}
if c.EgressProxy == nil {
c.EgressProxy = network.NewNoopEgressProxy()
}

return c
}
Expand Down
Loading