Skip to content

fix(envd): use WithoutCancel for CA cleanup goroutine ctx #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkamar merged 1 commit into from
Jul 4, 2026
Merged

fix(envd): use WithoutCancel for CA cleanup goroutine ctx #3207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/envd/internal/host/cacerts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,10 @@ func (c *CACertInstaller) install(ctx context.Context, certPEM, bundlePath, extr
Dur("append_duration", time.Since(start)).
Msg("CA cert appended to bundle")

go func() { //nolint:contextcheck // background cleanup must outlive the caller's ctx
go func() {
cleanStart := time.Now()

_ = c.mu.Acquire(context.Background(), 1)
_ = c.mu.Acquire(context.WithoutCancel(ctx), 1)
Comment thread
arkamar marked this conversation as resolved.
defer c.mu.Release(1)

// A newer install has taken over; let that goroutine handle cleanup.
Expand Down
Loading