Skip to content

chore(main): release client-proxy 1.0.0 #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlie-e2b merged 1 commit into from
Jul 7, 2026
Merged

chore(main): release client-proxy 1.0.0 #3213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"packages/docker-reverse-proxy": "0.2.2",
"packages/client-proxy": "0.0.0",
"packages/client-proxy": "1.0.0",
"packages/clickhouse": "1.0.0"
}
13 changes: 13 additions & 0 deletions packages/client-proxy/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,22 @@

### Features

* Adding client-proxy and clickhouse to e2b-artifacts ([#3210](https://github.com/e2b-dev/infra/issues/3210)) ([5686d88](https://github.com/e2b-dev/infra/commit/5686d881e4c5c8a1712a5bd09a74b198172701b3))


### Bug Fixes

* **local-dev:** rename API_GRPC_ADDRESS to API_INTERNAL_GRPC_ADDRESS in local dev env ([#2589](https://github.com/e2b-dev/infra/issues/2589)) ([6c0bcb1](https://github.com/e2b-dev/infra/commit/6c0bcb15d80c2f33e23102c18f22cc6ea49cfd8e))
* push client-proxy, dashboard-api, and docker-reverse-proxy image… ([#2953](https://github.com/e2b-dev/infra/issues/2953)) ([1d930ee](https://github.com/e2b-dev/infra/commit/1d930ee60fd74b3ad1d5c167165b1005baa471fe))

## 1.0.0 (2026-07-07)


### Features

Check warning on line 19 in packages/client-proxy/CHANGELOG.md

View check run for this annotation

Claude / Claude Code Review

Duplicate 1.0.0 release entry in CHANGELOG 

The CHANGELOG will contain two identical `## 1.0.0 (2026-07-07)` blocks after merge — the newly added block duplicates the pre-existing block already present at HEAD (both have byte-identical Features and Bug Fixes entries). Root cause: PR #3211 merged the initial 1.0.0 CHANGELOG entry without bumping `.release-please-manifest.json` (it stayed at `0.0.0`), so release-please generated another 1.0.0 release PR that layers a second block on top. Consider closing this PR or manually squashing the du
Comment on lines 8 to +19

@claude claude Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The CHANGELOG will contain two identical ## 1.0.0 (2026-07-07) blocks after merge — the newly added block duplicates the pre-existing block already present at HEAD (both have byte-identical Features and Bug Fixes entries). Root cause: PR #3211 merged the initial 1.0.0 CHANGELOG entry without bumping .release-please-manifest.json (it stayed at 0.0.0), so release-please generated another 1.0.0 release PR that layers a second block on top. Consider closing this PR or manually squashing the duplicate block before merging, and fixing the release-please workflow so the manifest omission does not recur.

Extended reasoning...

What the bug is

After this PR merges, packages/client-proxy/CHANGELOG.md will contain two byte-identical ## 1.0.0 (2026-07-07) sections stacked on top of each other. The diff prepends a new 1.0.0 block (with the same Features and Bug Fixes) above the 1.0.0 block that PR #3211 already wrote to the file. The resulting file has two identical release headers for the same version — a malformed changelog by any standard convention.

Step-by-step proof

  1. Run git show 47b4fc7 -- packages/client-proxy/CHANGELOG.md (PR chore(main): release client-proxy 1.0.0 #3211, chore(main): release client-proxy 1.0.0). It shows the file being created with a single ## 1.0.0 (2026-07-07) block containing the same Features + Bug Fixes entries seen in this PR.
  2. Read the base-branch packages/client-proxy/CHANGELOG.md — it already has that 1.0.0 block at lines 3–14 (approximately).
  3. Read the diff in this PR: it inserts a new ## 1.0.0 (2026-07-07) header at line 8 followed by identical Features/Bug Fixes bullets, above (not replacing) the existing block.
  4. The post-merge file (shown in the modified-files context above) confirms it: lines 3–14 and 16–27 are byte-for-byte identical ## 1.0.0 (2026-07-07) sections.

Why release-please did this

Look at .release-please-manifest.json at the base of this PR: packages/client-proxy is still pinned to 0.0.0, even though PR #3211 already released 1.0.0. PR #3211's diff only touched the CHANGELOG — it did not update the manifest. Because the manifest is release-please's source of truth for "what version have I released," release-please believes 1.0.0 has not shipped yet and generates another 1.0.0 release PR. That PR's job is to (a) bump the manifest 0.0.0 → 1.0.0 (correct) and (b) prepend a new 1.0.0 CHANGELOG block (incorrect — one already exists).

Impact

Documentation-only. Runtime behavior of client-proxy, packaging, tagging, and container publishing are unaffected. The visible artifact is a malformed CHANGELOG that human readers will find confusing — two identical headers for the same date + version, back to back.

Fix

Two options, either resolves the immediate merge problem:

  1. Close this PR. PR chore(main): release client-proxy 1.0.0 #3211 already released 1.0.0. Then manually update .release-please-manifest.json on main to set packages/client-proxy: "1.0.0" so release-please stops proposing this release. This is the cleanest path since the release already happened.
  2. Squash the duplicate block before merging. Edit packages/client-proxy/CHANGELOG.md in this PR to delete one of the two identical 1.0.0 blocks, then merge. The manifest bump 0.0.0 → 1.0.0 is still correct and will prevent future duplicate PRs.

Either way, worth investigating why PR #3211 merged with a CHANGELOG update but no manifest update — that is the underlying process gap that produced this duplicate release PR.


* Adding client-proxy and clickhouse to e2b-artifacts ([#3210](https://github.com/e2b-dev/infra/issues/3210)) ([5686d88](https://github.com/e2b-dev/infra/commit/5686d881e4c5c8a1712a5bd09a74b198172701b3))


### Bug Fixes

* **local-dev:** rename API_GRPC_ADDRESS to API_INTERNAL_GRPC_ADDRESS in local dev env ([#2589](https://github.com/e2b-dev/infra/issues/2589)) ([6c0bcb1](https://github.com/e2b-dev/infra/commit/6c0bcb15d80c2f33e23102c18f22cc6ea49cfd8e))
Expand Down