Skip to content

refactor(orchestrator): reuse parsed metadata for copy-build SQL output #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkamar merged 1 commit into from
Jul 20, 2026
Merged

refactor(orchestrator): reuse parsed metadata for copy-build SQL output #3308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 2 additions & 29 deletions packages/orchestrator/cmd/copy-build/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package main

import (
"context"
"encoding/json"
"errors"
"flag"
"fmt"
Expand Down Expand Up @@ -410,35 +409,9 @@ func main() {
fmt.Fprintf(os.Stderr, "Build '%s' copied to '%s'\n", *buildId, *to)

if *teamID != "" {
// Read metadata.json from destination to get kernel and firecracker versions.
var metadataReader io.ReadCloser
if strings.HasPrefix(*to, "gs://") {
bucketName, _ := strings.CutPrefix(*to, "gs://")
obj := googleStorageClient.Bucket(bucketName).Object(metadataPath)
r, err := obj.NewReader(ctx)
if err != nil {
log.Fatalf("failed to read metadata from GCS: %s", err)
}
metadataReader = r
} else {
f, err := os.Open(path.Join(*to, "templates", metadataPath))
if err != nil {
log.Fatalf("failed to read metadata from local path: %s", err)
}
metadataReader = f
}

var meta struct {
Template struct {
KernelVersion string `json:"kernel_version"`
FirecrackerVersion string `json:"firecracker_version"`
} `json:"template"`
}
if err := json.NewDecoder(metadataReader).Decode(&meta); err != nil {
metadataReader.Close()
log.Fatalf("failed to decode metadata.json: %s", err)
if meta.Template.KernelVersion == "" || meta.Template.FirecrackerVersion == "" {
log.Fatalf("kernel/firecracker version missing in build metadata (version %d), cannot generate SQL", meta.Version)
}
metadataReader.Close()

envID := id.Generate()
fmt.Fprintf(os.Stderr, "\n\nGenerated env ID: %s\n\n", envID)
Expand Down
Loading