Skip to content

fix(envd): replace time.Sleep with ticker in ScanAndBroadcast for prompt shutdown #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkamar merged 4 commits into from
Jul 24, 2026
Merged

fix(envd): replace time.Sleep with ticker in ScanAndBroadcast for prompt shutdown #3374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4f7a55
fix(envd): replace time.Sleep with ticker in ScanAndBroadcast for pro…
AdaAibaby Jul 24, 2026
64ae9b1
test(envd): drop timing-based port scanner shutdown tests
arkamar Jul 24, 2026
1a4039b
docs(envd): revert ScanAndBroadcast doc comment to its original form
arkamar Jul 24, 2026
5857aa3
chore(envd): bump version to 0.6.11
arkamar Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/envd/internal/port/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ func (s *Scanner) Unsubscribe(sub *ScannerSubscriber) {

// ScanAndBroadcast starts scanning open TCP ports and broadcasts every open port to all subscribers.
func (s *Scanner) ScanAndBroadcast() {
ticker := time.NewTicker(s.period)
defer ticker.Stop()

for {
// tcp monitors both ipv4 and ipv6 connections.
processes, _ := net.Connections("tcp")
Expand All @@ -52,8 +55,7 @@ func (s *Scanner) ScanAndBroadcast() {
select {
case <-s.scanExit:
return
default:
time.Sleep(s.period)
case <-ticker.C:
}
}
}
2 changes: 1 addition & 1 deletion packages/envd/pkg/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package pkg

const Version = "0.6.10"
const Version = "0.6.11"
Loading