Skip to content

[2467] Add connected elements tool to the General View - #2496

Merged
AxelRICHARD merged 1 commit into
mainfrom
cbr/enh/addreferenced
Sep 14, 2026
Merged

AxelRICHARD merged 1 commit into
mainfrom
cbr/enh/addreferenced

Conversation

@AxelRICHARD

@AxelRICHARD AxelRICHARD commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Expose existing elements connected to the selected element through both inbound and outbound General View relationships.

Add the tool icon and integration coverage.

Bug: #2467

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@AxelRICHARD AxelRICHARD added this to the 2026.11.0 milestone Aug 31, 2026
@AxelRICHARD AxelRICHARD linked an issue Aug 31, 2026 that may be closed by this pull request
@cbrun
cbrun force-pushed the cbr/enh/addreferenced branch 2 times, most recently from 51dcaf9 to f4d7a9c Compare September 1, 2026 13:18
@cbrun cbrun self-assigned this Sep 7, 2026
@cbrun
cbrun force-pushed the cbr/enh/addreferenced branch from 172ea3d to b9b655a Compare September 8, 2026 15:19
@cbrun

cbrun commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Following our discussion, the tool now excludes connected elements that can be represented as ports or inside a compartment/container of any selected node, even when the compartment is hidden. This uses the node descriptions rather than a blacklist of semantic types. Independent connected elements are still exposed, and existing representations are preserved.

Added unit and integration coverage, including single and multiple selections. The local build passes, and all coverage thresholds are met.

@cbrun
cbrun force-pushed the cbr/enh/addreferenced branch from b9b655a to 82e117e Compare September 8, 2026 15:35
@AxelRICHARD
AxelRICHARD force-pushed the cooldown branch 3 times, most recently from bb8c5cd to 569f669 Compare September 10, 2026 08:06

@AxelRICHARD AxelRICHARD left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better indeed 👍
Just few comments and it will be ok, thank you!

Comment thread CHANGELOG.adoc
@cbrun

cbrun commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@AxelRICHARD Thanks for the review! Both remaining comments are addressed in e11f9b2. Local Maven validation/Checkstyle, commit-message tests and all metadata checks pass.

Do you prefer keeping the individual commits as they are, or would you like me to squash them once the review is complete, before merging?

@cbrun
cbrun force-pushed the cbr/enh/addreferenced branch from e11f9b2 to d8f1b25 Compare September 10, 2026 17:40

@AxelRICHARD AxelRICHARD left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase, squash and merge it myself, thank you!

Expose existing elements connected to the selected element through both
inbound and outbound General View relationships.

Bug: #2467
Signed-off-by: Cedric Brun <cedric.brun@obeo.fr>
@AxelRICHARD
AxelRICHARD changed the base branch from cooldown to main September 14, 2026 07:32
@AxelRICHARD
AxelRICHARD merged commit 1a7d698 into main Sep 14, 2026
2 checks passed
@AxelRICHARD
AxelRICHARD deleted the cbr/enh/addreferenced branch September 15, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add existing connected elements to a General View

2 participants