Update CoreAdminConfigurationExtensions.cs FindDbContexts method to fix duplicated DbSets - #11
Merged
Conversation
…ix duplicated DbSets Hey @edandersen, here is a fix for the duplicated DbSets. I've tested it to work locally in my own project, but if you can test it with the demo that would be much appreciated! :-) The fix was to ensure checking if the implementation type of discovered services already has been discovered prior to adding the DiscoveredDbContextType to the services. Fixes #10
Owner
|
Love it but going to need an update to remove "target-typed object creation" as that's C# 9.0 / .NET 5 + only and the library also builds against .NET Core 3.1. Thanks :-) |
edandersen
reviewed
Aug 27, 2021
Owner
|
Lovely, merged! Thank you! |
Owner
|
Will be added to version 1.6.0 :) |
Contributor
Author
|
Happy to help :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @edandersen, here is a fix for the duplicated DbSets. I've tested it to work locally in my own project, but I would appreciate it if you can test it with the demo! :-)
The fix was to check if the implementation type of discovered services already has been discovered before adding the
DiscoveredDbContextTypeto the services.Fixes #10