feat: set window title under win32 platform - #63
Closed
waitingsong wants to merge 9 commits into
Closed
Conversation
Member
|
fell free to reopen if any other good idea. |
Contributor
Author
|
用 process.title 设置windows窗口标题，然后用 你这么急着关嘛呢…… |
Member
|
我以为是独立一个 egg-scripts-win 去做了。 |
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 98.32% 97.91% -0.42%
==========================================
Files 7 8 +1
Lines 419 431 +12
==========================================
+ Hits 412 422 +10
- Misses 7 9 +2
Continue to review full report at Codecov.
|
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
Apr 2, 2018
need egg-cluster patch: eggjs/cluster#63
4 tasks
Contributor
Author
|
npm stop with win32 support with this PR |
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
Apr 3, 2018
need with egg-cluster patch: eggjs/cluster#63
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
Apr 3, 2018
need with egg-cluster patch: eggjs/cluster#63
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
Apr 5, 2018
need with egg-cluster patch : eggjs/cluster#63
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
May 3, 2018
need egg-cluster patch: eggjs/cluster#63
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
May 3, 2018
need with egg-cluster patch: eggjs/cluster#63
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
May 3, 2018
need with egg-cluster patch: eggjs/cluster#63
waitingsong
added a commit
to waitingsong/egg-scripts
that referenced
this pull request
May 3, 2018
need with egg-cluster patch : eggjs/cluster#63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change