Mask script key in show/list/search output behind --reveal-key - #17
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
Closing — filing this as issue #18 instead so it goes through the normal ready-for-agent flow. |
devin-ai-integration
Bot
deleted the
devin/1790616899-mask-key-in-show
branch
September 28, 2026 17:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #14/#15: the fetch log no longer leaks the key, but
crmfetch showprinted it in its details table, andlist --json/search --jsondumped it inside the full tenant objects. Same exposure route as the log — scrollback, screenshares, pasted bug reports. Not a real secret boundary (the key sits in plaintext in tenant_settings.json), so this is deliberately opt-out rather than removal:show,listandsearcheach gained a--reveal-keyflag; masking applies to both the human-readable and--jsonforms, so scripts that need the value must ask for it explicitly.--jsonoutput is otherwise unchanged (same keys, same shape).crmfetch add/editstill take the key as an argument, and nothing about the request itself changed.Tests:
python -m pytest tests -q→ 90 passed (3 new; the existingshow --jsontest was updated for the intentional behaviour change). readme.md documents neithershownor--json, so nothing to update there.Link to Devin session: https://app.devin.ai/sessions/6daa0b67c92f45619f580de2a1e3c212
Open in Devin Desktop: https://app.devin.ai/desktop/session/6daa0b67c92f45619f580de2a1e3c212?variant=devin
Requested by: @ehs5