Skip to content

fix(gh-aw): keep object-shaped add_labels through allowlist sanitize - #1993

Merged
fr4nc1sc0-r4m0n merged 1 commit into
mainfrom
fix/add-labels-object-sanitize
Sep 3, 2026
Merged

fr4nc1sc0-r4m0n merged 1 commit into
mainfrom
fix/add-labels-object-sanitize

Conversation

@fr4nc1sc0-r4m0n

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Resolve add_labels entries as plain strings or { name } objects in the shared allowlist sanitize fragment and PR labeler source.
  • Recompile dependency-review, issue-triage, and pr-labeler locks so all consumers pick up the fix.
  • Add regression tests covering string labels, object-shaped labels, disallowed object labels, PR labeler source behavior, and compiled lock presence.

Why

After gh-aw ~v0.83.4, agents emit object-shaped labels. String(object) became "[object Object]", which failed classification-labels matching (Sanitized label ops: removed=1, dropped_messages=1). Comments still claimed labels were applied, so automerge never saw oblt-aw/ai/merge-ready.

Test plan

  • python3 -m pytest tests/test_safe_output_add_labels.py -v (7 passed)
  • make compile regenerated the three locks with the object-name sanitize
  • After merge, confirm a new low-risk bot dependency PR gets oblt-aw/ai/merge-ready applied

Related issue: elastic/oblt-aw#1813


The body of this PR is automatically managed by the Trigger Update PR Body workflow.

Agents emit {name,confidence,rationale} for labels; String(v) became
"[object Object]" and dropped every allowlisted label (including
oblt-aw/ai/merge-ready), breaking dependency-review and automerge.
@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n merged commit e6079da into main Sep 3, 2026
27 checks passed
@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n deleted the fix/add-labels-object-sanitize branch September 3, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants