Repository navigation
Fix timezone-aware --since filtering in fetch-workflow-logs - #2159
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes incorrect
--sincefiltering inscripts/fetch-workflow-logs.pywhen thesincevalue includes a timezone offset (for example,2025-01-01T00:00:00-05:00).Root cause: the script compared timestamps as raw strings, which is not chronologically correct across differing timezone representations.
What changed
_parse_iso8601_utc()to parse ISO 8601 timestamps (includingZand explicit offsets) and normalize to UTC._normalize_since()for date-only--sincevalues so they are interpreted as start-of-day UTC (T00:00:00Z), mirroring the existing date-only--untilnormalization.2025-01-01T04:30:00Zmust be excluded for--since 2025-01-01T00:00:00-05:00.Validation
UV_CACHE_DIR=/tmp/gh-aw/agent/uv-cache uv run --extra test pytest -q tests/test_fetch_workflow_logs.py make lintCloses #2158.
What is this? | From workflow: Trigger Bug Hunter
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.