Repository navigation
Fix workflow utility scripts to use requests and structural PyYAML edits - #2164
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Fixes #2163. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2163.
This PR implements both framework-best-practices findings in the utility scripts and adds focused regression tests:
scripts/fetch-workflow-logs.pyfrom manualurllibrequests torequests.Sessionwith centralized headers (Authorization, API version, accept), explicit timeout handling,raise_for_status(), and pagination via GitHubnextlinks.scripts/wire-ephemeral-token.pyto structural YAML mutation withyaml.safe_load/safe_dumpforid-token: writeinjection on token-minting jobs.create-tokenbut lacks apermissionsmapping, instead of silently skipping.tests/test_fetch_workflow_logs.pyandtests/test_wire_ephemeral_token.pyto cover auth header wiring, pagination behavior, indentation-variant YAML handling, and missing-permissions failure.Validation
UV_CACHE_DIR=/tmp/gh-aw/agent/uv-cache uv run --extra test pytest tests/test_fetch_workflow_logs.py tests/test_wire_ephemeral_token.py -q(13 passed)
Pre-Completion Checklist
make compileandmake lintwith no errorsWhat is this? | From workflow: Trigger Framework Best Practices
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.