feat(changelog): bundling resolves notes-{target}.json from CDN - #3929
Merged
Merged
Conversation
reakaleek
approved these changes
Aug 25, 2026
Contributor
There was a problem hiding this comment.
Requesting changes: notes target resolution is currently ambiguous for multi-target output and can silently produce incomplete bundles.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Mpdreamz
force-pushed
the
fix/changelog-notes-bundling
branch
from
August 26, 2026 07:30
aa0b140 to
bd3c98b
Compare
Mpdreamz
force-pushed
the
fix/changelog-notes-bundling
branch
from
August 26, 2026 07:56
bd3c98b to
1327886
Compare
Moves NotesIndex + NotesIndexJsonContext to Elastic.Documentation.Configuration
so both the CDN entry fetcher and the Lambda reconciler share one type.
Adds CdnChangelogEntryFetcher.FetchNotesAsync: fetches the per-target notes
index (changelog/{org}/{repo}/notes-{target}.json), a missing index returns []
with no error, a listed-but-absent note is a hard error.
ChangelogBundlingService.BundleChangelogs now calls FetchCdnNotesAsync after
matching PR entries when useCdn is true and an explicit target is available
via input.OutputProducts. Notes are merged with checksum-based dedup and passed
to BuildAndWriteBundle alongside the PR-matched entries.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…es complete for multi-target bundles Replace ResolveNoteTarget (returns first match) with ResolveNoteTargets (returns all distinct non-wildcard targets). MergeNotesAsync now fetches notes for every resolved target and merges them with dedup-by-checksum, so a bundle over two output targets (e.g. 8.19.0 and 9.0.0) fetches notes-8.19.0.json AND notes-9.0.0.json instead of silently dropping one. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mpdreamz
force-pushed
the
fix/changelog-notes-bundling
branch
from
August 26, 2026 08:09
1327886 to
be48672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotesIndex+NotesIndexJsonContextfromElastic.Changelog.ReconciliationtoElastic.Documentation.Configuration.ReleaseNotesso both the CDN fetcher and the Lambda reconciler share one definitionCdnChangelogEntryFetcher.FetchNotesAsync: fetcheschangelog/{org}/{repo}/notes-{target}.json; 404 → empty list (no error); listed-but-absent note → hard errorChangelogBundlingService.BundleChangelogsnow fetches and merges note entries whenuseCdnis true and an explicit target is available frominput.OutputProducts; dedup by checksum prevents duplicate entriesTest plan
Elastic.Documentation.Configuration.Testspassing (includes 4 newFetchNotesAsynctests)Elastic.Changelog.Testspassing (reconciler still uses the moved type)dotnet build -c Release— 0 errorsFetchNotesAsync_IndexAbsent_ReturnsEmptyWithNoErrorFetchNotesAsync_HappyPath_FetchesAllListedNotesFetchNotesAsync_ListedNoteNotFound_EmitsErrorAndReturnsEmptyFetchNotesAsync_EmptyIndex_ReturnsEmptyStacks on
fix/changelog-notes-reconciler(Step 5). Part of the two-anchor plan.Known gap (Step 9): the PR-based CDN sourcing (
FetchCdnEntriesAsync) still reads the pool registry that nothing writes post-#3760. Notes resolve correctly, but PR entries remain broken until Step 9 replaces the registry read with per-PR probing.🤖 Generated with Claude Code