fix: allow Elastic org members to trigger docs review on fork PRs - #6538
Merged
Conversation
The same-repo guard unconditionally blocked fork PRs from triggering the docs review, even when a repo member checked the box. Now the guard checks org membership first and only short-circuits for non-members. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The same-repo guard introduced in #6484 (SEC-043) unconditionally blocked fork PRs from triggering the docs review, even when the actor was an Elastic org member. This caused confusion (see #6537) where a repo member checking the box on a fork PR was silently ignored.
Change: the guard now calls
checkMembershipForUserbefore short-circuiting. Org members can trigger reviews on fork PRs; non-members are still blocked.The companion change in the canonical template is in elastic/oblt-aw#896.
Test plan
evaluate-triggerpasses, docs review runsevaluate-triggershort-circuits, no review🤖 Generated with Claude Code
Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com