fix: disable maven cache in release workflow - #424
Open
mallendem wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Hardens Maven CI and release workflows against dependency-cache poisoning.
Changes:
- Removes Maven caching from the shared workflow action.
- Enforces checksum validation failures.
- Updates
actions/setup-javato v6.
File summaries
| File | Summary |
|---|---|
.mvn/maven.config |
Enforces checksum validation failures. |
.github/workflows/maven-goal/action.yml |
Disables Maven caching and updates setup-java. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mallendem
enabled auto-merge (squash)
September 10, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache: 'maven'from theactions/setup-javastep in themaven-goalcomposite action, used by release workflows (pre-post-release.yml) as well as CI (test.yml).-Daether.checksumPolicy=failto.mvn/maven.configas defense in depth.actions/setup-javav4 -> v6 while touching this step.Why
Cache poisoning attack vector: a poisoned Maven dependency cache could be pulled into release artifacts. Same fix already applied and merged in the sibling repo apm-agent-java: elastic/apm-agent-java#4414.
Test plan
test.yml) passes without the Maven cachepre-post-release.ymlsteps still function correctly without the cache