StructlogFormatter conforms to structlog.typing.Processor - #147
Conversation
|
💚 CLA has been signed |
|
Is there anything that I can do to help move this forwards? |
|
I've updated this to address the latest merge conflicts, so this is ready to review again. |
xrmx
left a comment
There was a problem hiding this comment.
We run mypy in pre-commit, so instead of adding these tests and adding mypy as dev dependency we should update the mypy configuration in .pre-commit-config.yaml.
|
Sorry missed that the purpose of the typing test are testing the example. I guess that's fine then. |
|
I implemented it this way based on your comment here, but I wasn't sure if I'm interpreting what you meant correctly. |
This changes the function signature of
StructlogProcessor.__call__so that's it's compatible with structlog.typing.Processor.I've also removed the need for mypy to be run with
--no-warn-unused-ignores. The test was requiring this to be set, and therefore users would need to as well. With this change, users can run mypy with--strictand without needing to turn any other checks off.Closes #146