Skip to content

[ML] Downgrade redundant CStateDecompressor empty-state log to INFO - #3082

Merged
valeriy42 merged 2 commits into
elastic:mainfrom
valeriy42:mlcpp-quiet-json-log
Jul 22, 2026
Merged

[ML] Downgrade redundant CStateDecompressor empty-state log to INFO#3082
valeriy42 merged 2 commits into
elastic:mainfrom
valeriy42:mlcpp-quiet-json-log

Conversation

@valeriy42

Copy link
Copy Markdown
Contributor

Summary

Downgrade the redundant LOG_ERROR("Failed to find valid JSON") in CStateDecompressor::readHeader() to LOG_INFO with a clearer message for empty or missing compressed state documents. PR #2895 fixed the fatal categorizer-restore cascade but left this line at ERROR; it fires routinely when no categorizer state exists yet and was tripping the serverless log error-rate promotion gate. Genuine corruption remains ERROR-logged in parseNext().

Relates #2875

The LOG_ERROR at readHeader() for missing or empty compressed state
documents was never addressed in elastic#2895 and is redundant with parseNext()
diagnostics. Downgrade to INFO so routine categorizer state restore
misses no longer trip the serverless ERROR log-rate promotion gate.

Relates elastic#2875
@valeriy42
valeriy42 marked this pull request as draft July 21, 2026 14:58
@valeriy42
valeriy42 requested a review from edsavage July 21, 2026 18:30
@valeriy42
valeriy42 marked this pull request as ready for review July 21, 2026 18:30
@elasticsearchmachine

Copy link
Copy Markdown

Pinging @elastic/ml-core (Team:ML)

@edsavage edsavage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriy42 valeriy42 added auto-backport Automatically merge backport PRs when CI passes v9.4.5 v9.5.1 labels Jul 22, 2026
@valeriy42
valeriy42 merged commit bfaa5cd into elastic:main Jul 22, 2026
29 checks passed
@valeriy42
valeriy42 deleted the mlcpp-quiet-json-log branch July 22, 2026 06:56
@github-actions

Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
9.4
9.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions Bot added a commit that referenced this pull request Jul 24, 2026
…3082) (#3093)

The LOG_ERROR at readHeader() for missing or empty compressed state
documents was never addressed in #2895 and is redundant with parseNext()
diagnostics. Downgrade to INFO so routine categorizer state restore
misses no longer trip the serverless ERROR log-rate promotion gate.

Relates #2875

(cherry picked from commit bfaa5cd)

Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Jul 24, 2026
…3082) (#3092)

The LOG_ERROR at readHeader() for missing or empty compressed state
documents was never addressed in #2895 and is redundant with parseNext()
diagnostics. Downgrade to INFO so routine categorizer state restore
misses no longer trip the serverless ERROR log-rate promotion gate.

Relates #2875

(cherry picked from commit bfaa5cd)

Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically merge backport PRs when CI passes :ml >non-issue v9.4.5 v9.5.1 v9.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants