Conversation
5 tasks
Contributor
Author
|
Alrighty, I've been running this implementation against the Web Platform Tests (WPT) via a hacked-up version of undici's test harness, and it's doing pretty good so far: the remaining "unexpected failures" are:
In addition, net.fetch doesn't support I think none of these are sufficiently bad problems to prevent shipping, so I'm taking this out of draft mode. |
nornagon
marked this pull request as ready for review
January 26, 2023 20:33
erickzhao
reviewed
Jan 26, 2023
Contributor
Author
deepak1556
reviewed
Feb 14, 2023
deepak1556
left a comment
Member
There was a problem hiding this comment.
Seems like changes from #37099 are mixed in, a rebase would be good.
deepak1556
approved these changes
Feb 15, 2023
3 tasks
|
Release Notes Persisted
|
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Mar 15, 2023
4 tasks
8 tasks
7 tasks
This was referenced Jul 15, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This implements
net.fetch(), by analogy tofetch()on the Web andfetch()in Node, but using Chromium's network stack.
Checklist
npm testpassesRelease Notes
Notes: Added
net.fetch().