Skip to content

chore: replace eslint with oxlint - #174

Merged
MarshallOfSound merged 1 commit into
mainfrom
oxlint
Sep 18, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
oxlint

Conversation

@claude

@claude claude Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Before: yarn lint ran eslint 8 with @typescript-eslint, eslint-plugin-github, eslint-plugin-vitest and friends via .github/linters/.eslintrc.yml.

After: yarn lint runs oxlint --type-aware with a small .oxlintrc.json (mirrors electron/lint-roller), keeping the type-aware no-floating-promises check the source relies on.

  • Removed eslint, @typescript-eslint/{parser,eslint-plugin}, eslint-plugin-{github,import,jsonc,prettier,vitest}, eslint-import-resolver-typescript, prettier-eslint, and the now-unused typescript-estree/minimatch resolution
  • Added oxlint (1.81.0) and oxlint-tsgolint (7.0.2001)
  • Added .oxlintrc.json; deleted .eslintignore, .github/linters/.eslintrc.yml, .github/linters/tsconfig.json, and the .eslintcache gitignore entry
  • lint -> oxlint --type-aware, new lint:fix; eslint-disable comments converted to oxlint-disable
  • Dropped unused baseUrl from tsconfig.json (tsgolint rejects it) and made the package entry points explicit relative paths so esbuild no longer depends on it; CI already runs yarn lint, so no workflow changes

Verified locally: yarn lint, yarn format:check, yarn test (26 passing) and yarn package all pass; dist/ is unchanged.

Open question: vitest/require-mock-type-parameters (not in the old eslint config) is turned off in .oxlintrc.json; say the word if you'd rather annotate the four vi.fn() calls instead.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs


Generated by Claude Code

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedoxlint@​1.81.0991009196100
Addedoxlint-tsgolint@​7.0.20011001009792100

View full report

@MarshallOfSound
MarshallOfSound marked this pull request as ready for review September 12, 2026 23:43
@MarshallOfSound
MarshallOfSound requested review from a team as code owners September 12, 2026 23:43
@MarshallOfSound
MarshallOfSound merged commit 911c860 into main Sep 18, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the oxlint branch September 18, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants