chore: replace eslint with oxlint - #174
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
MarshallOfSound
marked this pull request as ready for review
September 12, 2026 23:43
MarshallOfSound
approved these changes
Sep 12, 2026
MarshallOfSound
enabled auto-merge (squash)
September 12, 2026 23:43
This was referenced Sep 12, 2026
codebytere
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Before:
yarn lintran eslint 8 with@typescript-eslint,eslint-plugin-github,eslint-plugin-vitestand friends via.github/linters/.eslintrc.yml.After:
yarn lintrunsoxlint --type-awarewith a small.oxlintrc.json(mirrorselectron/lint-roller), keeping the type-awareno-floating-promisescheck the source relies on.eslint,@typescript-eslint/{parser,eslint-plugin},eslint-plugin-{github,import,jsonc,prettier,vitest},eslint-import-resolver-typescript,prettier-eslint, and the now-unusedtypescript-estree/minimatchresolutionoxlint(1.81.0) andoxlint-tsgolint(7.0.2001).oxlintrc.json; deleted.eslintignore,.github/linters/.eslintrc.yml,.github/linters/tsconfig.json, and the.eslintcachegitignore entrylint->oxlint --type-aware, newlint:fix;eslint-disablecomments converted tooxlint-disablebaseUrlfromtsconfig.json(tsgolint rejects it) and made thepackageentry points explicit relative paths so esbuild no longer depends on it; CI already runsyarn lint, so no workflow changesVerified locally:
yarn lint,yarn format:check,yarn test(26 passing) andyarn packageall pass;dist/is unchanged.Open question:
vitest/require-mock-type-parameters(not in the old eslint config) is turned off in.oxlintrc.json; say the word if you'd rather annotate the fourvi.fn()calls instead.🤖 Generated with Claude Code
https://claude.ai/code/session_01Dp8HUuTkriy2qNUP2GNgcs
Generated by Claude Code