Implement nona-mask - #7
Open
stowersjoshua wants to merge 2 commits into
Open
Conversation
The original from Panotools::Script does not forward all of our arguments properly. We have provided a patch for this, but it has not yet been released. This binary file contains that patch. https://sourceforge.net/p/panotools/Panotools-Script/merge-requests/1/ A new `Binaries` module has been added so we can reference the abstraction cleanly and change it back to just `nona-mask` globally later on. Signed-off-by: stowersjoshua <stowers.joshua@live.com>
It is disabled by default, and can be enabled with the `--with-masking` flag. nona-mask is picky about where the project file is specified, so it has been moved to the beginning of the command. This ordering is still fully compatible with with the original `nona` command. Signed-off-by: stowersjoshua <stowers.joshua@live.com>
evanscottgray
approved these changes
Nov 6, 2020
evanscottgray
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you!
Can you push a minor version bump? :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
nona-maskscript from Panotools::Script does not forward all of our arguments properly.We have provided a patch for this, but it has not yet been released.
This binary file contains that patch.
Its usage is disabled by default, and can be enabled with the
--with-maskingflag.