Skip to content

Parse tabs correctly - #29

Merged
josevalim merged 1 commit into
elixir-makeup:masterfrom
joshprice:fix-tabs
Jul 17, 2024
Merged

Parse tabs correctly#29
josevalim merged 1 commit into
elixir-makeup:masterfrom
joshprice:fix-tabs

Conversation

@joshprice

@joshprice joshprice commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

I don't support tabs and certainly not mixed with spaces but this should not produce errors.

Note: not sure what \s is supposed to be matching? worth double checking whether it's really needed.

Fixes #28

@josevalim

Copy link
Copy Markdown
Contributor

\s is a regular whitespace.

@josevalim
josevalim merged commit 3d1ba96 into elixir-makeup:master Jul 17, 2024
@josevalim

Copy link
Copy Markdown
Contributor

💚 💙 💜 💛 ❤️

@joshprice

Copy link
Copy Markdown
Contributor Author

In regex, that makes sense but confused about the usage here. Is \s matching a space here, as it clearly doesn't match tabs?

@josevalim

Copy link
Copy Markdown
Contributor

Yes, it is matching a single space: ?\s == 32.

I was going to publish a new version but i forgot to push v1.0.0 from the machine when i released it. So i will have to do it from home in a week.

@joshprice
joshprice deleted the fix-tabs branch July 17, 2024 02:25
@joshprice

Copy link
Copy Markdown
Contributor Author

Thanks for clarifying. No hurry on my end, just stumbled across it while enjoying the new OTP docs ;)

garazdawi pushed a commit to garazdawi/makeup_erlang that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs are interpreted as errors

2 participants