Update optional-features.json - #10440
Merged
Merged
Conversation
19 tasks
mansona
reviewed
Feb 14, 2024
achambers
marked this pull request as ready for review
February 14, 2024 15:26
achambers
marked this pull request as draft
February 14, 2024 15:32
mansona
reviewed
Feb 14, 2024
Member
|
The CI is failing with the message:
Does this mean that we can't merge this until the version of ember-source that defines this optional feature is actually released? I don't know if we've done any version guarding on optional-features before 🤔 |
Member
|
Ah looking into it it's probably because @ember/optional-features hasn't been shipped. I'll work on get that released and this should start passing, and we should probably bump the version in the blueprint too to be safe ;) |
achambers
force-pushed
the
achambers-patch-1
branch
from
February 21, 2024 15:20
e1e6058 to
99b6578
Compare
Adding `no-implicit-route-model` for emberjs/rfcs#970
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
kategengler
force-pushed
the
achambers-patch-1
branch
from
February 28, 2024 22:57
0257be1 to
130ff55
Compare
kategengler
marked this pull request as ready for review
February 29, 2024 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
no-implicit-route-modelfor emberjs/rfcs#970TODO
true