Disable modifier auto-tracking. - #16
Merged
Merged
Conversation
The original RFC specifically defines when these modifier methods should be called, and in all scenarios the semantics of when to re-fire (only applicable to `did-update`) exclude auto-tracking. did-insert ---------- [From the RFC](https://github.com/emberjs/rfcs/blob/master/text/0415-render-element-modifiers.md#did-insert): > This modifier is activated only when The element is inserted in the DOM. did-update ---------- [From the RFC](https://github.com/emberjs/rfcs/blob/master/text/0415-render-element-modifiers.md#did-update): > This modifier is activated only on updates to it's arguments (both > positional and named). It does not run during or after initial render, > or before element destruction. will-destroy ------------ [From the RFC](https://github.com/emberjs/rfcs/blob/master/text/0415-render-element-modifiers.md#will-destroy) > This modifier is activated: > > - immediately before the element is removed from the DOM.
pzuraq
approved these changes
Oct 2, 2019
Member
Author
|
CI is failing on Node 6 due to socketio/engine.io#589. |
|
awesome! |
|
This couldn't have been merged at a better time. We were running into infinite loops with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original RFC specifically defines when these modifier methods should be called, and in all scenarios the semantics of when to re-fire (only applicable to
did-update) exclude auto-tracking.did-insert
From the RFC:
did-update
From the RFC:
will-destroy
From the RFC