Skip to content

[DOC Release] Mark multiple methods in Ember.Router as public - #12763

Closed
mikepmunroe wants to merge 6 commits into
emberjs:masterfrom
mikepmunroe:mm-router-doc-updates
Closed

[DOC Release] Mark multiple methods in Ember.Router as public#12763
mikepmunroe wants to merge 6 commits into
emberjs:masterfrom
mikepmunroe:mm-router-doc-updates

Conversation

@mikepmunroe

Copy link
Copy Markdown
Contributor

Mark Ember.Router.url as public
Mark Ember.Router.startRouting as public
Mark Ember.Router.isActive as public
Mark Ember.Router.isActiveIntent as public
Mark Ember.Router.hasRoute as public
Mark Ember.Router.reset as public

@acorncom

acorncom commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

Doesn't seem identical, but may be related to #12211

@rwjblue

rwjblue commented Jan 8, 2016

Copy link
Copy Markdown
Member

@acorncom - Ya, definitely related but distinct.

@mikepmunroe - I'm unsure if all of these were intended to be public API's. I would like @machty's thoughts here, as he has the most context into the intent....

@machty

machty commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

I don't think we should mark these public. If there are any of these we definitely need/want, it'd be better to make note of it as part of the Routing Service PR

@mikepmunroe

Copy link
Copy Markdown
Contributor Author

Closing this. We will add requests to the Routing Service PR, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants