[CLEANUP] Remove DEPRECATE_COMPONENT_TEMPLATE_RESOLVING deprecation - #20891
Merged
kategengler merged 4 commits intoApr 1, 2025
Merged
Conversation
Contributor
Development AssetsDiff --- main/out.txt 2025-03-28 16:02:56.000000000 +0000
+++ pr/./pr-14203619291/out.txt 2025-04-01 18:49:06.000000000 +0000
@@ -1,6 +1,6 @@
2.2M └─┬ .
1015K ├─┬ @ember
- 206K │ ├─┬ -internals
+ 205K │ ├─┬ -internals
69K │ │ ├─┬ views
64K │ │ │ └─┬ lib
23K │ │ │ ├── mixins
@@ -14,7 +14,7 @@
26K │ │ ├─┬ meta
21K │ │ │ └── lib
11K │ │ ├── owner
- 9.6K │ │ ├── deprecations
+ 9.4K │ │ ├── deprecations
7.4K │ │ ├── metal
7.0K │ │ ├── string
5.1K │ │ ├── glimmerDetails
|
Contributor
|
awww yeeee, look at that 0.2KB reduction! nice! |
kategengler
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #20816.
The removal of this deprecation means that the resolver's internal function
layoutForwould always returnnull. It's only called in one place, so I removed the function and updatedlookupComponentPairto usenullin place of the return fromlayoutFor.While doing the cleanup, we determined that some of the tests were erroneously marked with the deprecation, so for those tests -- in the
tests/integration/components/append-test.jsfile -- thetestUnlesswrapper was removed. One test was modified to build the test component usingtemplateinstead ofresolvableTemplate.