Skip to content

Fix bug where includer never got added - #17

Open
Oipo wants to merge 1 commit into
emilk:masterfrom
Oipo:master
Open

Fix bug where includer never got added#17
Oipo wants to merge 1 commit into
emilk:masterfrom
Oipo:master

Conversation

@Oipo

@Oipo Oipo commented Sep 3, 2021

Copy link
Copy Markdown

No description provided.

@Oipo

Oipo commented Sep 3, 2021

Copy link
Copy Markdown
Author

Brainfart moment, the signature of the function is const DocInfo_SP& doc()... which returns a reference anyway.

@Oipo Oipo closed this Sep 3, 2021
@Oipo

Oipo commented Sep 3, 2021

Copy link
Copy Markdown
Author

Nope, was right after all: https://godbolt.org/z/sszYbWYrb

@Oipo Oipo reopened this Sep 3, 2021
@amiteshsingh-cpi

Copy link
Copy Markdown

Nope, was right after all: https://godbolt.org/z/sszYbWYrb

not required, if the object is of type shared_ptr.

https://godbolt.org/z/jnoPYddEq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants